Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added chlamy growth curve assay #5

Merged
merged 5 commits into from
Mar 13, 2024
Merged

added chlamy growth curve assay #5

merged 5 commits into from
Mar 13, 2024

Conversation

dgmets
Copy link
Collaborator

@dgmets dgmets commented Mar 7, 2024

I have added a single assay file that covers most of the functionalities in cam_tools.py Let me know what you think!

Thanks!

@dgmets dgmets requested a review from taylorreiter March 7, 2024 20:22
Copy link
Member

@taylorreiter taylorreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question. I'm approving but can you make sure linting passes before you merge?

to grow ("grow lights"), then acquires an image using transillumination once an hour
for 48 hours'''

dev=ser.Serial('/dev/ttyACM0') # establish serial communication with microcontroller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this always be the same path no matter who the user is?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be the same path if you are using a linux machine and have only one phenotypeomat attached to the machine. There are more complicated USB device handling systems, but I didn't mess around with those. I will add this as an issue for future development!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I added a statement about the fact that you can only have one PTOmat attached at a time.

@dgmets dgmets merged commit 4afc226 into main Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants